[core] Avoid repeated sorted-index source lookups - #9187
Merged
Conversation
Primary-key sorted-index scans linearly searched each source group to locate every data file, making source localization quadratic in the number of files. Build a file-name lookup alongside source offsets and preserve row-count validation when creating file-local readers. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Primary-key sorted-index scans previously located each data file by linearly walking its source group. Repeating the lookup for every file made source localization quadratic in the number of source files.
Build a file-name-to-source-location map alongside the existing offsets so file-local readers use constant-time lookups while preserving row-count validation.
Tests
mvn -pl paimon-core -DwildcardSuites=none -Dtest=PrimaryKeySortedIndexScanTest test